Skip to content

lib: fprotect: testing #22643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

lib: fprotect: testing #22643

wants to merge 1 commit into from

Conversation

nordicjm
Copy link
Contributor

@nordicjm nordicjm commented Jun 4, 2025

testing with nrf54l15

@nordicjm
lib: fprotect: testing
42d7ba4 
testing with nrf54l15

Signed-off-by: Jamie McCrae <[email protected]>
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jun 4, 2025
@NordicBuilder
Copy link
Contributor

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
mcuboot nrfconnect/sdk-mcuboot@4532c33 (main) nrfconnect/sdk-mcuboot#446 nrfconnect/sdk-mcuboot#446/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 4, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 42d7ba44484456fc495ba666f69f1e109485aa6d
mcuboot: PR head: ab160b6cadc9f76da6b5c6df7b5a3e3a45222aa1

more details

sdk-nrf:

PR head: 42d7ba44484456fc495ba666f69f1e109485aa6d
merge base: 900df0379b8ef9f3d5e62a16fe3cc1d060ad40a1
target head (main): 9f429255e4c599925e4699b3edffdd2fe082d27b
Diff

mcuboot:

PR head: ab160b6cadc9f76da6b5c6df7b5a3e3a45222aa1
merge base: 4532c33e13400f8686067605764b1cde0d07ff7a
target head (main): b37f58b7fa7221fe2fd4e9d0ca0a2567e5279bc0
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4) 
bootloader
│  ├── mcuboot
│  │  ├── boot
│  │  │  ├── zephyr
│  │  │  │  ├── boards
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ prj.conf
lib
│  ├── fprotect
│  │  │ Kconfig
west.yml

Outputs:

Toolchain

Version: 4aa3467a6d
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4aa3467a6d_e85602c25f

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 688
  • ❌ Integration tests
    • ✅ test-fw-nrfconnect-boot
    • ❌ test-sdk-mcuboot
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025

You can find the documentation preview for this PR here.

@michalek-no michalek-no marked this pull request as ready for review June 4, 2025 15:06
@michalek-no michalek-no requested review from a team as code owners June 4, 2025 15:06
nvlsianpu
nvlsianpu requested changes Jun 5, 2025
View reviewed changes
lib/fprotect/Kconfig
@@ -51,6 +51,8 @@ menuconfig FPROTECT
depends on SOC_FAMILY_NORDIC_NRF
depends on !(SOC_SERIES_NRF54LX && IS_SECURE_BOOTLOADER)
select NRFX_RRAMC if SOC_SERIES_NRF54LX
default y if MCUBOOT && (!SOC_SERIES_NRF54LX || (SOC_SERIES_NRF54LX && MCUBOOT_MCUBOOT_IMAGE_NUMBER = -1))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add comment there about reasoning, something like: enabled by default for MCUboot build as only bootloader on nRF54L SoC's. Similar below, mcuboot might use both RRAM regions 3 & 4 as it's allone.

@NordicBuilder
Copy link
Contributor

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvlsianpu nvlsianpu nvlsianpu requested changes

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-mcuboot Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nordicjm @NordicBuilder @nvlsianpu